-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle parsing fields containing an empty relation list in and out of storage #336
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #336 +/- ##
==========================================
+ Coverage 89.27% 89.53% +0.26%
==========================================
Files 70 68 -2
Lines 5881 5143 -738
==========================================
- Hits 5250 4605 -645
+ Misses 631 538 -93
... and 25 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
95a73ca
to
44d3bad
Compare
b3d4cc0
to
88bc6fc
Compare
#334
In order to do this we make
value
on operation and document field rows optional and interpret this to mean an empty relation list when parsing values from the store.Then this threw up another bug which i believe originates in
p2panda-rs
where we don't handle decoding pinned relation lists if they contain no items. p2panda/p2panda#489📋 Checklist
CHANGELOG.md