Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make value on QueryRow an option #339

Merged
merged 6 commits into from
Apr 25, 2023

Conversation

sandreae
Copy link
Member

@sandreae sandreae commented Apr 25, 2023

📋 Checklist

  • Add tests that cover your changes
  • Add this PR to the Unreleased section in CHANGELOG.md
  • Link this PR to any issues it closes
  • New files contain a SPDX license header

@sandreae sandreae marked this pull request as ready for review April 25, 2023 15:52
@codecov
Copy link

codecov bot commented Apr 25, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.26 🎉

Comparison is base (784a0ef) 89.46% compared to head (49938fa) 89.72%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #339      +/-   ##
==========================================
+ Coverage   89.46%   89.72%   +0.26%     
==========================================
  Files          70       70              
  Lines        5998     6093      +95     
==========================================
+ Hits         5366     5467     +101     
+ Misses        632      626       -6     
Impacted Files Coverage Δ
aquadoggo/src/db/models/query.rs 100.00% <ø> (ø)
aquadoggo/src/db/stores/query.rs 94.68% <100.00%> (+0.41%) ⬆️
aquadoggo/src/graphql/queries/all_documents.rs 100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@sandreae sandreae changed the title Graphql empty pinned relation query bug Make value on QueryRow an option Apr 25, 2023
@sandreae sandreae merged commit 4019af6 into main Apr 25, 2023
@adzialocha adzialocha deleted the graphql-empty-pinned-relation-query-bug branch April 25, 2023 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants