Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct selection of comparison field during pagination #471

Merged
merged 3 commits into from
Jul 27, 2023
Merged

Conversation

adzialocha
Copy link
Member

@adzialocha adzialocha commented Jul 27, 2023

Closes: #470

📋 Checklist

  • Add tests that cover your changes
  • Add this PR to the Unreleased section in CHANGELOG.md
  • Link this PR to any issues it closes
  • New files contain a SPDX license header

@adzialocha adzialocha marked this pull request as ready for review July 27, 2023 11:50
@codecov
Copy link

codecov bot commented Jul 27, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (27e84cd) 91.83% compared to head (49645ca) 91.83%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #471   +/-   ##
=======================================
  Coverage   91.83%   91.83%           
=======================================
  Files         100      100           
  Lines       15736    15738    +2     
=======================================
+ Hits        14451    14453    +2     
  Misses       1285     1285           
Files Changed Coverage Δ
aquadoggo/src/db/stores/query.rs 96.13% <100.00%> (+<0.01%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@adzialocha adzialocha requested a review from sandreae July 27, 2023 15:34
@sandreae sandreae merged commit c4947ef into main Jul 27, 2023
10 checks passed
@adzialocha adzialocha deleted the fix-query-bug branch July 27, 2023 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Paginated and filtered queries break on updated data
2 participants