Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve log level user interface #539

Merged
merged 3 commits into from
Aug 30, 2023
Merged

Improve log level user interface #539

merged 3 commits into from
Aug 30, 2023

Conversation

adzialocha
Copy link
Member

@adzialocha adzialocha commented Aug 30, 2023

# Set aquadoggo=INFO
LOG_LEVEL=info aquadoggo

# .. same, but via command line argument
aquadoggo --log-level info

# Set _all_ to INFO
aquadoggo --log-level "=info"

# ... etc.
aquadoggo --log-level "aquadoggo=INFO,libp2p=DEBUG"

# One can also set the value in config.toml (haven't included it in the template since using it there seems unlikely)

Closes: #537, #536, #534

📋 Checklist

  • Add tests that cover your changes
  • Add this PR to the Unreleased section in CHANGELOG.md
  • Link this PR to any issues it closes
  • New files contain a SPDX license header

This was linked to issues Aug 30, 2023
@codecov
Copy link

codecov bot commented Aug 30, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (bcf0fbb) 92.20% compared to head (49c4f3a) 92.20%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #539   +/-   ##
=======================================
  Coverage   92.20%   92.20%           
=======================================
  Files         102      102           
  Lines       16108    16108           
=======================================
+ Hits        14852    14853    +1     
+ Misses       1256     1255    -1     

see 4 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@adzialocha adzialocha marked this pull request as ready for review August 30, 2023 12:43
Copy link
Member

@sandreae sandreae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is excellent!!

@sandreae sandreae closed this Aug 30, 2023
@sandreae sandreae deleted the log-level branch August 30, 2023 13:38
@adzialocha adzialocha restored the log-level branch August 30, 2023 13:50
@adzialocha adzialocha reopened this Aug 30, 2023
@adzialocha adzialocha merged commit 9c8c49e into main Aug 30, 2023
18 checks passed
@adzialocha adzialocha deleted the log-level branch August 30, 2023 13:50
adzialocha added a commit that referenced this pull request Sep 6, 2023
* main:
  Minor README.md updates
  0.5.0
  Prepare README for v0.5.0 release (#532)
  Set unix cfg correctly
  Do only set permissions mode on unix
  Update RELEASE.md
  Improve log level user interface (#539)
  Move deserialization into `PeerMessage` to distinct variants correctly (#538)
  Bring back all connection handler logs to warn level again
  Add compiling windows binaries as well, remove macos universal one
  Adjust release profile
  Add checksum when releasing binaries
  Add v0.5.0 to CHANGELOG.md
  Add armv7-unknown-linux-gnueabihf target for cross compilation CI
  Add CI to compile and publish releases
  Make clippy happy
  Convert to ip addresses when logging multiaddr on info level
  Increase log level of handler errors to trace-level
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants