Use write_all
when writing blob data to file system
#587
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should use
write_all
instead ofwrite
when writing blob data to the filesystem as the latter only represents a "single attempt" to write a buffer to a file, whereas the former "continuously calls [write] until there is no more data to be written" or an error occurs. In using the later we were sometimes silently failing to write all data to the file system.Closes #586
📋 Checklist
CHANGELOG.md