Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make keypairs #4

Merged
merged 7 commits into from
Nov 30, 2020
Merged

Make keypairs #4

merged 7 commits into from
Nov 30, 2020

Conversation

cafca
Copy link
Member

@cafca cafca commented Nov 13, 2020 •
edited
Loading

@cafca
Copy link
Member Author

cafca commented Nov 13, 2020

status: tests run but importing the lib from Javascript fails with

Uncaught (in promise) ReferenceError: can't access lexical declaration '__wbg_self_1c83eb4471d9eb9b' before initialization

@adzialocha
Copy link
Member

status: tests run but importing the lib from Javascript fails with

Uncaught (in promise) ReferenceError: can't access lexical declaration '__wbg_self_1c83eb4471d9eb9b' before initialization

This is an issue related to Webpack 5 + wasm-bindgen: rustwasm/wasm-bindgen#2343 and was fixed in p2panda/zoo-adventures@f7e4770 by using the (older and sadly uglier) sync wasm-import method of Webpack as a workaround.

@adzialocha
Copy link
Member

Also, I'm running into problems with the post-build steps of wasm-opt similar to this problem described here: rustwasm/wasm-pack#886 the recommended steps of adding the --enable-mutable-globals flag did not solve the problem so I pinned wasm-bindgen to an older version 0.2.65 which made it work again.

cafca
cafca commented Nov 15, 2020
View reviewed changes
src/lib.rs Show resolved Hide resolved
@cafca cafca marked this pull request as ready for review November 15, 2020 15:18
@adzialocha adzialocha linked an issue Nov 16, 2020 that may be closed by this pull request
Methods for ed25519 key pair generation #1
Closed
@cafca
Copy link
Member Author

cafca commented Nov 16, 2020

I have added the hex encoding!

#7

@adzialocha adzialocha merged commit 43d81b3 into main Nov 30, 2020
@adzialocha adzialocha deleted the make-keypair branch November 30, 2020 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adzialocha adzialocha adzialocha left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Methods for ed25519 key pair generation
2 participants
@cafca @adzialocha