Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pin mapping #47

Merged
merged 4 commits into from
Jul 14, 2024
Merged

Fix pin mapping #47

merged 4 commits into from
Jul 14, 2024

Conversation

ellensp
Copy link
Contributor

@ellensp ellensp commented Jul 14, 2024

Recent changes in Marlin MarlinFirmware/Marlin@ce796ce broke the Simulator under bugfix

Update function names so it builds again

@ellensp
Copy link
Contributor Author

ellensp commented Jul 14, 2024

Note M43 does not work on the sim,
It didn't work before the commit that broke compiling also

@p3p
Copy link
Owner

p3p commented Jul 14, 2024

Thanks, will try and sort out a stable commit for use in Marlin,

M43 doesnt work because of the way pins debugging was designed, I use the information for the UI so it cant be used by Marlin,

@ellensp
Copy link
Contributor Author

ellensp commented Jul 14, 2024

Ah yes, you mentioned this before, sadly my pudding brain forgot (till now)

@p3p p3p merged commit a2e6fb2 into p3p:master Jul 14, 2024
@ellensp ellensp deleted the fix-pin-mapping branch July 15, 2024 02:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants