Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MarlinHAL 2.0.9.3 #9

Merged
merged 1 commit into from
Dec 27, 2021
Merged

MarlinHAL 2.0.9.3 #9

merged 1 commit into from
Dec 27, 2021

Conversation

thinkyhead
Copy link
Contributor

Updated API for HALs proposed for Marlin 2.0.9.3. A new version tag – or branch – will be required for the benefit of ini/native.ini. Or, we could host a fork of MarlinSimUI under MarlinFirmware … if that's easier to manage.

See MarlinFirmware/Marlin#23295

@p3p
Copy link
Owner

p3p commented Dec 14, 2021

Thanks for sorting this out, it shouldn't be necessary to fork as long as the HAL API doesn't change constantly, I prefer to keep this as an external library. Where I drew the line at what is in the Marlin HAL implementation and what I moved to the library could be tweaked if its a problem.

I will sort out a release, possibly push it to PlatformIOs library manager too although direct links are fine as its just a dev tool don't need to worry as much about backwards compatibility.

@thinkyhead
Copy link
Contributor Author

Current versions of Marlin refer to master.zip specifically, which is why I thought it may be better to keep that branch as it is, then put these changes in a new branch that can start to have version tags. Since GitHub is leaning towards "main" to replace "master" maybe you can put the new versioned code into a branch with that name…? If in future you want to delete the "master" branch, then a tag called "master" should automagically work in its place.

@p3p
Copy link
Owner

p3p commented Dec 15, 2021

Being a development tool MarlinSimUI has only tried to be compatible with Marlin bugfix-2.0.x so Marlins native.ini targets the master branch as it should, the master branch is currently not compatible with any previous version of Marlin.

If you need to have a compatible version for each official Marlin release then that could be done, although you would need to update native.ini before each release to target the "stable" version, .. or just target a specific commit.

@p3p p3p merged commit 15d05a0 into p3p:master Dec 27, 2021
@thinkyhead
Copy link
Contributor Author

You probably already reverted this, as there were bugs when I tried to apply the change to all the HALs at once. I'll try and apply it more gradually for better chance of success.

@thinkyhead thinkyhead deleted the updated_marlin_hal_2093 branch January 5, 2022 01:52
@descipher
Copy link

Please revert.

p3p added a commit that referenced this pull request Jan 6, 2022
@p3p p3p mentioned this pull request Jan 6, 2022
p3p added a commit that referenced this pull request Jan 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants