Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add struct field pruning support #14

Merged
merged 14 commits into from
Feb 22, 2022
Merged

Add struct field pruning support #14

merged 14 commits into from
Feb 22, 2022

Conversation

robotrobo
Copy link
Collaborator

No description provided.

@robotrobo robotrobo marked this pull request as ready for review February 11, 2022 01:40
Copy link
Contributor

@fruffy fruffy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments. Mostly high level.

pruner/.clang-tidy Outdated Show resolved Hide resolved
pruner/src/extended_unused.cpp Outdated Show resolved Hide resolved
pruner/src/compiler_pruner.cpp Outdated Show resolved Hide resolved
pruner/src/extended_unused.cpp Show resolved Hide resolved
pruner/src/extended_unused.cpp Show resolved Hide resolved
pruner/src/extended_unused.cpp Outdated Show resolved Hide resolved
pruner/src/extended_unused.cpp Outdated Show resolved Hide resolved
pruner/src/extended_unused.cpp Outdated Show resolved Hide resolved
pruner/src/expression_pruner.cpp Outdated Show resolved Hide resolved
pruner/src/compiler_pruner.cpp Outdated Show resolved Hide resolved
@p4gauntlet p4gauntlet deleted a comment from fruffy-bfn Feb 17, 2022
@p4gauntlet p4gauntlet deleted a comment from fruffy-bfn Feb 17, 2022
@fruffy
Copy link
Contributor

fruffy commented Feb 18, 2022

There is a failing test. One of the ref files has changed.

@@ -1,17 +1,43 @@
#include "extended_unused.h"

#include "frontends/p4/sideEffects.h"
#include "ir/ir-generated.h"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do not include this file. Instead include ir/ir.h

@fruffy fruffy merged commit 87f243d into master Feb 22, 2022
@fruffy fruffy deleted the add_struct_pruning branch February 22, 2022 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants