Add missing await for closing incognito browser context. #170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sangitamane
approved these changes
Dec 13, 2021
|
@sangitamane Is there any chance of this being pushed out as a patch release? At a minimum async reporters using incognito are broken (or at least flaky) without it (especially when processing data in |
|
I can merge this in master, but I am afraid if I can release it! So @josebolos or @joeyciechanowicz may release it once they are back. |
|
I'm on holiday without a laptop currently, but will release when I'm back
on Monday. Great work!
…On Fri, 17 Dec 2021, 15:45 Sangita Mane, ***@***.***> wrote:
Merged #170 <#170> into master.
—
Reply to this email directly, view it on GitHub
<#170 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAIYNXMUTRYL2OEWLMKX5Q3URNLITANCNFSM5JZ2K5KQ>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
Released in v3.0.1. Thanks @aarongoldenthal! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add missing
awaitfor closing incognito browser context. Errors have been seen running custom reporters with async functions, as noted in #168 (comment), with the stack trace pointing to this line. ThebrowserContext.closefunction is async, so without theawaitthere appears to be timing issues between thebrowserContext.closeand parentbrowser.close(which are likely masked in other cases by pa11y-ci completing and exiting the process).This change did resolve at least the reporter problem noted in #168 (as did running with
"useIncognitoBrowserContext": falseas a workaround). The build-in reporters (cli/html) are only synchronous code and don't appear to cause it.I haven't seen this with other execution as noted in #168, so not clear if it will resolve the other issues, but those errors do also point to this line of code.