Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforce scalar eltype of mesh vertices #101

Merged
merged 2 commits into from
Sep 25, 2020
Merged

Enforce scalar eltype of mesh vertices #101

merged 2 commits into from
Sep 25, 2020

Conversation

pablosanjose
Copy link
Owner

@pablosanjose pablosanjose commented Sep 25, 2020

Closes #75

This errors informatively if we try to make a marchingmesh of non-Number vertex eltype, and enforces the constraint at the MeshSpec and Mesh levels.

@pablosanjose pablosanjose changed the title Enforce numerical mesh vertices Enforce scalar eltype of mesh vertices Sep 25, 2020
@codecov-commenter
Copy link

codecov-commenter commented Sep 25, 2020

Codecov Report

Merging #101 into master will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #101      +/-   ##
==========================================
+ Coverage   62.02%   62.04%   +0.01%     
==========================================
  Files          16       16              
  Lines        2652     2653       +1     
==========================================
+ Hits         1645     1646       +1     
  Misses       1007     1007              
Impacted Files Coverage Δ
src/mesh.jl 93.33% <100.00%> (+0.04%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 52372c6...6720c76. Read the comment docs.

@pablosanjose pablosanjose merged commit bb9572c into master Sep 25, 2020
@pablosanjose pablosanjose deleted the fix_75 branch September 30, 2020 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mixing non-scalar parameters and Bloch phases
2 participants