Faster bands
: do set_blas_threads(1)
before diagonalization, then restore
#226
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The diagonalization step in
bands
is multithreaded over momenta. BLAS is also multithreaded by default. But actual diagonalization of matrices is more difficult to multithread than the loop over momenta, so it is much faster to switch to 1 single BLAS thread for the diagonalization step inbands
, and then return to whatever it was before. The difference is specially dramatic usingEigenSolvers.LinearAlgebra
, to the point in which it is the fastest method (with multithreading) up to pretty large unit cells (like here, with 200 orbitals, 8 threads)Master:
This PR: