Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite GreenFunction plotting #251

Merged
merged 3 commits into from
Mar 5, 2024
Merged

Rewrite GreenFunction plotting #251

merged 3 commits into from
Mar 5, 2024

Conversation

pablosanjose
Copy link
Owner

@pablosanjose pablosanjose commented Mar 4, 2024

Closes #250

The old graphical representation of GreenFunctions was quite lacking and confusing.

This implements a new way of plotting GreenFunctions that includes boundaries, self-energy sites and sites/couplings of children Hamiltonians coupled to said sites. The latter are shown with squares/cubes instead of circles/spheres.

An example

julia> glead = LP.honeycomb() |> hopping(1, range = 1) |> supercell((1,-1), region = r -> 0<=r[2]<=5) |> attach(nothing, cells = SA[5]) |> greenfunction(GS.Schur(boundary = 0));

julia> g = LP.honeycomb() |> hopping(1) |> supercell(region = r -> -6<=r[1]<=6 && 0<=r[2]<=5) |> attach(glead, region = r -> r[1] > 4.9) |> greenfunction;

julia> qplot(g, shellopacity = 0.3)

Screenshot 2024-03-04 at 19 34 00

remove plotables and qplot(::GreenFunction)

fix typo, restore simplified qplot(::GreenFunction)

WIP

corner cases

test fix

complete plottables, enable qplot!(green)

fix recursive_push! forward

fix tests
@codecov-commenter
Copy link

codecov-commenter commented Mar 4, 2024

Codecov Report

Attention: Patch coverage is 82.35294% with 12 lines in your changes are missing coverage. Please review.

Project coverage is 92.07%. Comparing base (624c354) to head (139364f).
Report is 1 commits behind head on master.

Files Patch % Lines
src/solvers/selfenergy/schur.jl 66.66% 9 Missing ⚠️
src/solvers/green/bands.jl 0.00% 2 Missing ⚠️
src/types.jl 91.66% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #251      +/-   ##
==========================================
- Coverage   92.16%   92.07%   -0.10%     
==========================================
  Files          35       36       +1     
  Lines        5823     5857      +34     
==========================================
+ Hits         5367     5393      +26     
- Misses        456      464       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pablosanjose pablosanjose merged commit e35966a into master Mar 5, 2024
9 checks passed
@pablosanjose pablosanjose mentioned this pull request Apr 25, 2024
@pablosanjose pablosanjose deleted the greenplot branch October 25, 2024 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Schur leads with additional self-energies are broken
2 participants