Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add transform keyword to generic attach method (second try) #263

Merged
merged 2 commits into from
Apr 17, 2024

Conversation

pablosanjose
Copy link
Owner

@pablosanjose pablosanjose commented Apr 12, 2024

This adds transform to attach(::GreenSlice, ::AbstractModel; transform = ..., sites...)

We also check against empty contact selections, which formerly threw an obscure error. Now the error is more explicit.

@codecov-commenter
Copy link

codecov-commenter commented Apr 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.48%. Comparing base (4276162) to head (ca5253e).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #263   +/-   ##
=======================================
  Coverage   92.48%   92.48%           
=======================================
  Files          36       36           
  Lines        5880     5882    +2     
=======================================
+ Hits         5438     5440    +2     
  Misses        442      442           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pablosanjose pablosanjose changed the title Add transform keyword to generic attach method - second try Add transform keyword to generic attach method (second try) Apr 12, 2024
@pablosanjose pablosanjose merged commit 415a810 into master Apr 17, 2024
9 checks passed
@pablosanjose pablosanjose deleted the atransform2 branch April 24, 2024 16:06
@pablosanjose pablosanjose mentioned this pull request Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants