Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accept keywords after comma in parametric model macros #275

Merged
merged 1 commit into from
Apr 23, 2024

Conversation

pablosanjose
Copy link
Owner

Closes #118

We also reduce code repetition in macros by condensing all functionality into a single parse_term function

(Note that @onsite(r -> 2, sublats) is also accepted if sublats has been defined in scope, as in common functions)

@codecov-commenter
Copy link

codecov-commenter commented Apr 23, 2024

Codecov Report

Attention: Patch coverage is 92.30769% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 92.53%. Comparing base (55f1659) to head (481963f).
Report is 10 commits behind head on master.

Files Patch % Lines
src/models.jl 92.30% 2 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #275      +/-   ##
==========================================
- Coverage   92.54%   92.53%   -0.01%     
==========================================
  Files          37       37              
  Lines        6100     6106       +6     
==========================================
+ Hits         5645     5650       +5     
- Misses        455      456       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pablosanjose pablosanjose merged commit b9caac3 into master Apr 23, 2024
9 checks passed
@pablosanjose pablosanjose deleted the semicolon branch April 24, 2024 16:02
@pablosanjose pablosanjose mentioned this pull request Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

@onsite! and @hopping! don't understand comma after function
2 participants