BandrangeKPM(::Hamiltonian) support for non-scalar eltype #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosKPM(ham) and densityKPM(ham) typo rebase
pablosanjose
force-pushed
the
flatbandrange
branch
from
c73149f
to
38c69dd
Compare
Codecov Report
@@ Coverage Diff @@
## master #71 +/- ##
==========================================
+ Coverage 56.72% 61.13% +4.41%
==========================================
Files 15 15
Lines 2267 2267
==========================================
+ Hits 1286 1386 +100
+ Misses 981 881 -100
Continue to review full report at Codecov.
|
…jl.git; branch 'flatbandrange' of github.com:pablosanjose/Quantica.jl into flatbandrange
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #62
This introduces
BandrangeKPM(::Hamiltonian), that is called whenevermomentaKPM(::Hamiltonian)receives abandrange === missing.BandrangeKPM(h)now supports flatteningbloch(h)through thebloch!/similarmatrixmachinery, and hence properly deals with non-scalar eltypes. This PR does not cover the case wheremomentaKPMis called on anAbstractArraywith non-scalar eltype, as the mentioned machinery is only defined on Hamiltonians. It might be interesting to generalize in the future.We need to make sure some basic KPM tests pass before merging.