Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draw intercell hoppings as full lines in VegaLite #90

Merged
merged 3 commits into from
Sep 19, 2020
Merged

Conversation

pablosanjose
Copy link
Owner

This makes it equivalent to the behaviour with Makie.

Before:
Screen Shot 2020-09-19 at 20 20 10

After:
Screen Shot 2020-09-19 at 20 20 19

@codecov-commenter
Copy link

codecov-commenter commented Sep 19, 2020

Codecov Report

Merging #90 into master will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #90   +/-   ##
=======================================
  Coverage   63.16%   63.16%           
=======================================
  Files          16       16           
  Lines        2701     2701           
=======================================
  Hits         1706     1706           
  Misses        995      995           
Impacted Files Coverage Δ
src/plot_vegalite.jl 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 315ca79...1cc0b3a. Read the comment docs.

@pablosanjose pablosanjose merged commit 17648aa into master Sep 19, 2020
@pablosanjose pablosanjose deleted the vlite_links branch September 21, 2020 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants