feat: Show autocomplete hashtags with usage counts, sort by popularity #807
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When autocompleting hashtags while composing a status the previous code showed the hashtags in the same order they're returned by the server, with no additional information. This doesn't allow the user to make an informed choice about which hashtag might be better to use. For example, trying to choose between "#nivenly" and "#NivenlyFoundation". To fix that, include the hashtag's usage when receiving data from the server. Sum that, and show it to the user in the hashtag list. Sort the hashtags by popularity, most popular first.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When autocompleting hashtags while composing a status the previous code showed the hashtags in the same order they're returned by the server, with no additional information.
This doesn't allow the user to make an informed choice about which hashtag might be better to use. For example, trying to choose between "#nivenly" and "#NivenlyFoundation".
To fix that, include the hashtag's usage when receiving data from the server. Sum that, and show it to the user in the hashtag list. Sort the hashtags by popularity, most popular first.