fix: Tolerate missing status fields on veganism.social #911
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
veganism.social is doing something weird that injects statuses into the user's timeline that are missing the fields that are normally present on authenticated statuses. So far I've noticed: - `reblogged` - `favourited` - `bookmarked` on the top level `Status` are missing, and if the status contains a poll the `voted` field is also missing. Cover up this breakage by setting defaults for these fields.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
veganism.social is doing something weird that injects statuses into the user's timeline that are missing the fields that are normally present on authenticated statuses.
So far I've noticed:
rebloggedfavouritedbookmarkedon the top level
Statusare missing, and if the status contains a poll thevotedfield is also missing.Cover up this breakage by setting defaults for these fields.