fix: AlpineBonded ENI template bad bond options #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When both bond-master and bond-slaves are present, bond-slaves is ignored. This leads to the bond-* options associated with the bond-slaves stanza to be ignored as well. We observed that this led to provisioned Alpine linux machines to have balance-rr (mode 3) bonding mode instead of 802.3ad (mode 4) bonding mode. This caused packets to be sent out-of-order, leading to TCP/IP congestion control due to packet loss. Removing the bond-master option from the ethX stanzas fixes this issue and ensures the bonding driver uses our declared bond-* options in the bond stanzas.
ScottGarman
approved these changes
Aug 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant JIRA
https://equinixjira.atlassian.net/browse/BMS-898
What does this PR do?
Updates the Alpine bonded template to remove the
bond-masteroption from theethXstanzas.Why is this necessary?
When both bond-master and bond-slaves are present, bond-slaves is ignored. This leads to the bond-* options associated with the bond-slaves stanza to be ignored as well. We observed that this led to provisioned Alpine linux machines to have balance-rr (mode 3) bonding mode instead of 802.3ad (mode 4) bonding mode. This caused packets to be sent out-of-order, leading to TCP/IP congestion control due to packet loss.
Removing the bond-master option from the ethX stanzas fixes this issue and ensures the bonding driver uses our declared bond-* options in the bond stanzas.
(How) Has This Been Tested?
In CI, by hand with
a3.large.x86andn3.xlarge.x86provisions, and OSIE