Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add overlay and content className to dialog part #114

Merged
merged 1 commit into from
Apr 11, 2023

Conversation

joaom00
Copy link
Contributor

@joaom00 joaom00 commented Apr 11, 2023

In #69, says to add className to the Root and Overlay parts but since the Root part is just a react context it doesn't accept a className. I think they meant to add to the Content part.

Closes #69

@vercel
Copy link

vercel bot commented Apr 11, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
cmdk-website ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 11, 2023 3:33pm

Copy link
Owner

@pacocoursey pacocoursey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm okay with this for now, but we should probably just expose these parts separately in a future release.

@pacocoursey pacocoursey merged commit 3492270 into pacocoursey:main Apr 11, 2023
@joaom00 joaom00 deleted the overlay-content-classname branch April 11, 2023 16:04
@WalterZou
Copy link

@pacocoursey Please release a new version that includes this feature update🙏🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable className on the Overlay and Root
3 participants