Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use offsetHeight to calculate list height #121

Merged
merged 1 commit into from
Apr 17, 2023
Merged

Use offsetHeight to calculate list height #121

merged 1 commit into from
Apr 17, 2023

Conversation

joaom00
Copy link
Contributor

@joaom00 joaom00 commented Apr 17, 2023

Closes #120

@vercel
Copy link

vercel bot commented Apr 17, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
cmdk-website ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 17, 2023 5:33pm

pacocoursey
pacocoursey approved these changes Apr 17, 2023
View reviewed changes
Copy link
Owner

@pacocoursey pacocoursey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank youu

@pacocoursey pacocoursey merged commit 64bef04 into pacocoursey:main Apr 17, 2023
@joaom00 joaom00 deleted the offset-height branch April 17, 2023 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pacocoursey pacocoursey pacocoursey approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use offsetHeight instead of getBoundingClientRect to calculate list height
2 participants
@joaom00 @pacocoursey