Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add data-disabled to Item and recommend using data attributes #122

Merged
merged 3 commits into from
Apr 18, 2023
Merged

Add data-disabled to Item and recommend using data attributes #122

merged 3 commits into from
Apr 18, 2023

Conversation

joaom00
Copy link
Contributor

@joaom00 joaom00 commented Apr 17, 2023

Following what was said in #77 I believe it should also apply to aria-disabled and for consistency. This PR adds:

  • Add data-disabled attribute to Item part
  • Update docs and examples to recommend using data-attributes instead of aria-attributes

@vercel
Copy link

vercel bot commented Apr 17, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
cmdk-website ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 17, 2023 10:33pm

@pacocoursey pacocoursey merged commit 0d74730 into pacocoursey:main Apr 18, 2023
@joaom00 joaom00 deleted the data-attributes branch April 18, 2023 14:42
@kevinmitch14 kevinmitch14 mentioned this pull request Nov 18, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pacocoursey pacocoursey pacocoursey approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joaom00 @pacocoursey