Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: only scroll into view on first render and via keyboard #135

Merged
merged 2 commits into from
Jan 30, 2024
Merged

fix: only scroll into view on first render and via keyboard #135

merged 2 commits into from
Jan 30, 2024

Conversation

joaom00
Copy link
Contributor

@joaom00 joaom00 commented May 14, 2023

Fix some issues with scroll into view when item value is changed

  • Scroll into view only on first render in uncontrolled/controlled mode (fixes the issue where the item is scrolled with pointer events, if controlled)
  • Scroll into view if defaultValue prop is provided

@vercel
Copy link

vercel bot commented May 14, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
cmdk-website ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 14, 2023 9:07pm

@pyyding
Copy link

pyyding commented Oct 26, 2023

Would be cool if this was merged

@meyer-avest
Copy link

Hello, can you merge this please? @pacocoursey

@pacocoursey pacocoursey merged commit 9b97580 into pacocoursey:main Jan 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pacocoursey pacocoursey pacocoursey approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@joaom00 @pyyding @meyer-avest @pacocoursey