Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(keybinds): last fn respects disabled items #47

Merged
merged 5 commits into from
Sep 5, 2022
Merged

fix(keybinds): last fn respects disabled items #47

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
ce619bb
fix(keybinding): Meta+ArrowDown respects disabled items
thiskevinwang Sep 5, 2022
f5d9cca
chore(keybinds): update test
thiskevinwang Sep 5, 2022
6bb270a
revert id change
thiskevinwang Sep 5, 2022
1d63b80
chore: update test
thiskevinwang Sep 5, 2022
0ce9105
remove .only
pacocoursey Sep 5, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion test/keybind.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ test.describe('arrow keybinds', async () => {
await expect(page.locator(`[cmdk-item][aria-selected="true"]`)).toHaveAttribute('data-value', 'first')
})

test.only('meta arrow up/down goes to first and last item', async ({ page }) => {
thiskevinwang marked this conversation as resolved.
Show resolved Hide resolved
test('meta arrow up/down goes to first and last item', async ({ page }) => {
await expect(page.locator(`[cmdk-item][aria-selected="true"]`)).toHaveAttribute('data-value', 'first')
await page.locator(`[cmdk-input]`).press('Meta+ArrowDown')
await expect(page.locator(`[cmdk-item][aria-selected="true"]`)).toHaveAttribute('data-value', 'last')
Expand Down