Allow keyboard navigation even when text input is not focused #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… input is not focused
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Any updates on this? We are experiencing the same issue. |
|
Would love this feature as I am looking to exactly the same thing. |
|
Same here. Would love to have this feature |
|
+1 |
jaem1n207
pushed a commit
to jaem1n207/synchronize-tab-scrolling
that referenced
this pull request
Jan 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug
When the search input is not focused, the navigation keys don't work as expected. In the screencap below, I click elsewhere inside the palette and press the up/down arrow keys, but it scrolls the list/page instead of navigating through the list items.
720.Screen.Recording.2022-11-02.at.2.29.26.PM.mov
Fix
This fix allows the
cmdk-rootdiv to capture the navigation keybindings. This also allows the developer to use a custom search input outside the context of<Command>...</Command>(which is my use-case 😋)