Make zone serial increment properly

[gadall]

Zone serial was resetting (decrementing) when saving zone, and failing to increment when editing/adding/removing a record.

[pacoorozco]

I've seen you're addressing the use case when the serial is empty. Would you be so kind to add a test for this specific case?

[gadall]

@pacoorozco This became a problem because I changed ZoneController::fillZoneFromRequest to call getNewSerialNumber() instead of assign $zone->serial = Zone::generateSerialNumber(). This introduced the case of ! isset($this->serial).
The reason for that change was that this assignment was re-setting and decrementing serial numbers when the zone was being saved.

I'm not too familiar with Laravel etc., I see right now you're doing:
$zone = factory(Zone::class)->create();
$expectedSerial = $zone->serial;
and that worked, so I suppose this creates a zone with a pre-seeded serial?
So the test you're asking for would be more like:
$zone = new Zone();
$zone->getNewSerialNumber();
$this->assertGreaterThan(0, $zone->serial);

[pacoorozco]

Hi @gadall
Thanks a lot for raising this PR. I've just suggested to add a test to cover the use case that you have found.

[pacoorozco]

@gadall This should be fixed in the current 1.x version (main branch)