added an optional cronjob to perform the dbclean (external trigger)

[sherifkayad]

fixes #51

Implementing the external DB Clean Task recommended as per the docs https://docs.pact.io/pact_broker/docker_images/pactfoundation#running-the-clean-task-from-an-external-source

• Got rid of the DB Clean inside the Deployment
• Utilized a CronJob to perform the cleanup
• Generalized logging & db env vars (included them in the helm helpers file) as they are now re-usable across the CronJob & the Deployment

[sherifkayad]

@ChrisJBurns would be great if you can have a look at this one 😉

[ChrisJBurns]

Thanks for this @sherifkayad I'll give it a review when I've got a bit more time, I'll have to make sure that it all templates as expected as well

[sherifkayad]

@ChrisJBurns TYT and let me know if anything needs to be changed

[ChrisJBurns]

@sherifkayad Just had a look at this, we should probably make the CronJob optional for the database clean just to keep things simple in the vanilla install. So by default, if someone installs a single Pact Broker with 1 replica, then that single instance can be the container that runs the clean. But for folks who have more of a replicated setup of the Pact Brokers, we can allow them to enable the DBClean CronJob, a bit of documentation in the README.md about this would be a good thing too, just so users are aware of the ways the DB Clean can be done 👍

So a few tweaks, but all round great addition! 👍

[sherifkayad]

@sherifkayad thanks for the feedback. Let me take care of that and submit something you can have a look at. Will ping you once I add something there.

[sherifkayad]

@ChrisJBurns can you please have a look now? I also added some docs in the README about that new feature and overall about the DB Cleanup Task.

[sherifkayad]

@ChrisJBurns any updates from your side to the latest changes done?

[ChrisJBurns]

@sherifkayad Yep, I plan on taking a look on Friday as it's bank holiday here in the UK 👍

[sherifkayad]

Awesome! Same here in Germany .. Happy Easter holidays and let me know if there is anything I can do

[ChrisJBurns]

/lgtm