Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(verification): pass validation error message on #114

Merged
merged 1 commit into from
Oct 16, 2017

Conversation

thombergs
Copy link
Contributor

Verification error message is now passed on instead of being swallowed.

I'm not sure if it has any side effects, but at least for my use case (through karma-pact) this change made the experience of writing consumer tests much more pleasant, since I can now see what went wrong in the karma results in the browser.

fixes #113

@coveralls
Copy link

coveralls commented Oct 15, 2017

Coverage Status

Coverage remained the same at 95.767% when pulling ca0b052 on thombergs:errorhandling into f5387a0 on pact-foundation:master.

@mefellows
Copy link
Member

It makes sense. Could you please elaborate as to why the stack trace should be removed? It's typical of a test framework to output the results to a terminal, but I suspect perhaps this is less helpful in the Karma-like use cases?

@coveralls
Copy link

coveralls commented Oct 16, 2017

Coverage Status

Coverage remained the same at 95.767% when pulling a381198 on thombergs:errorhandling into f5387a0 on pact-foundation:master.

@coveralls
Copy link

coveralls commented Oct 16, 2017

Coverage Status

Coverage remained the same at 95.767% when pulling 3041282 on thombergs:errorhandling into 6d2ad81 on pact-foundation:master.

@thombergs
Copy link
Contributor Author

Took a couple commits to fix the test, because I couldn't get them to run on Windows (might make a separate PR for that), so I force pushed a clean history. The CI build still fails however, but because of some other reason.

I removed the error log since I assumed whatever framework is calling the verify() function will output the error as it sees fit and I don't see why it should be logged twice.

I'm not very deep into the JS ecosystem, however, so I don't really know the best practice here :).

@mefellows
Copy link
Member

Thanks. Not sure what is going on with the Node 4.x.x build but it's related to the karma examples I updated in master last night, not your change which is good to bring in.

Let's see how this goes!

@mefellows mefellows merged commit c559a08 into pact-foundation:master Oct 16, 2017
@mefellows mefellows mentioned this pull request Oct 16, 2017
31 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

verification error message is swallowed
3 participants