GraphQLInteraction doesn't support named queries

[sh3pik]

Apollo allows naming operations for a query or a mutation. It can be specified right after a keyword, e.g. query, and goes to operationName in the body of the request

A valid request must contain either a query or an operationName (or both, in case of a named query)

query HomeBookListing {
  getBooks {
    title
  }
}

{
  "body": {
    "query": "query HomeBookListing { getBooks { title } }",
    "operationName": "HomeBookListing"
  }
}

Expected behaviour

I expect .withOperation() to work with named operations.

Actual behaviour

.withOperation() allows only query or mutation:

You must provide a valid HTTP method: query, mutation.

[mefellows]

Thanks @sh3pik, it makes sense to support this.

Can you please show me exactly what you'd like the DSL to look like and also what you've tried?

[sh3pik]

I expect to be able to do something like:

new GraphQLInteraction()
.withOperation('HomeBookListing')
.withQuery('query HomeBookListing { getBooks { title } }')

If I run it on the current version, I'll get the error You must provide a valid HTTP method: query, mutation.
I tried without .withOperation('HomeBookListing'), I saw the error No matching interaction found in logs:

Diff
--------------------------------------
Key: - is expected 
     + is actual 
Matching keys and values are not shown

 {
   "body": {
-    "operationName": null
+    "operationName": "HomeBookListing"
   }
 }

Description of differences
--------------------------------------
* Expected nil but got "HomeBookListing" at $.body.operationName

[mefellows]

Thanks @sh3pik, having another look at the docs I think we are just being a little bit too strict on what the withOperation takes - it's really up to the user. I'll remove the restriction and error message for that field.

[mefellows]

I've pushed out a new release with a fix (16df628), let us know how you go!

[sh3pik]

The fix works perfectly! Thanks a lot for a quick response!

[mefellows]

You're welcome, thanks for the report!

…

On Sun, Oct 28, 2018, 1:36 AM Tatiana Shepeleva ***@***.***> wrote: The fix works perfectly! Thanks a lot for a quick response! — You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub <#235 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AADSjNWEzEyb50tMX-gHf7avDrrwIgS5ks5upG93gaJpZM4X65QR> .