Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Resolve package.json for version metadata regardless of nesting #174

Merged

Conversation

Thorn1089
Copy link
Contributor

The package.json file appears at a different relative location in the source tree versus the compiled package.
It should be resolved regardless of the level of nesting present in the calling module.

Relates to #173

The package.json file appears at a different relative location in the source tree versus the compiled package.
It should be resolved regardless of the level of nesting present in the calling module.

Relates to pact-foundation#173
@coveralls
Copy link

coveralls commented Apr 20, 2018

Coverage Status

Coverage increased (+0.04%) to 94.359% when pulling db41b53 on TomRK1089:feat/message-pact into a2d64b7 on pact-foundation:feat/message-pact.

@mefellows mefellows merged commit 9b771c6 into pact-foundation:feat/message-pact Apr 20, 2018
@mefellows
Copy link
Member

Awesome - thanks for this! I'll push out a new alpha shortly...

@mefellows
Copy link
Member

hmm, merge build failed: https://travis-ci.org/pact-foundation/pact-js/builds/368919159?utm_source=email&utm_medium=notification

It's ok as it's not critical, but something to address when you/I get a moment.

@mboudreau
Copy link
Contributor

@mefellows Why would the path change on release?

@Thorn1089
Copy link
Contributor Author

Yes I just noticed the Jest tests were failing (somehow missed that when running locally). Trying to investigate now.

@Thorn1089
Copy link
Contributor Author

@mboudreau When the logger.ts module is referencing the package.json, its relative path is ../../package.json as the module is under src/common. After compilation, logger.js is under common (no more src directory) and thus the relative path fails when using the published version of the module.

@Thorn1089
Copy link
Contributor Author

@mefellows trying again in #175 and seeing if Travis agrees with what I see in npm test locally now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants