feat(karma): relax consumer/provider requirement in MockService #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- For pact-web use cases, where mock service is started independently of the test cases themselves, we allow consumer and provider to be specified in underlying mock service directly. - Logs warning to console if details aren't provided to assist in debugging issues - Addresses pact-foundation/karma-pact/pull/4 - Addresses #59
|
I'm going to merge this in, and release as a new major version - |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See pact-foundation/karma-pact#4 (comment) and #59 (comment) for background.
independently of the test cases themselves, we allow
consumer and provider to be specified in underlying
mock service directly.
assist in debugging issues