Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'Template Objects' in PactDslJsonBoday and PactDslJsonArray #104

Closed
jamessawle opened this issue Mar 25, 2015 · 1 comment
Closed

'Template Objects' in PactDslJsonBoday and PactDslJsonArray #104

jamessawle opened this issue Mar 25, 2015 · 1 comment

Comments

@jamessawle
Copy link

Currently, each Pact must explicitly define each part of its expected response. Whilst this gives clarity on exactly what is expected, this can make them difficult to read when there are repeated Objects in a response, or even across responses. Especially when one of the 'template objects' has 30 fields and nested arrays as well'

As such it would be nice to make the protected 'putObject' methods public on both the PactDslJsonBody and the PactDslJsonArray. On the array, it would also be beneficial to be able to have a second wrapper method that allowed for the object to be added n times.

Any ideas would be much appreciated, and I will prepare a pull request.

@uglyog
Copy link
Member

uglyog commented Mar 27, 2015

Closing, as pull request was merged

@uglyog uglyog closed this as completed Mar 27, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants