fix: ConsumerContractBuilder exposing incorrect field #185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcotc
force-pushed
the
fix/ConsumerContractBuilder-name-fix
branch
from
e0000db
to
c805c3e
Compare
|
Sorry this has taken me so long. I think the attribute reader has the wrong name and should be : consumer_contract_details. It should probably also be private. |
|
I assume the correct fix would be to rename the accessor, but considering it should be private, we should just remove it from the accessor |
|
updated in #313. thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe
ConsumerContractBuilderis trying to exposeattr_reader :consumer_contract, but it's incorrectly setting that value to@consumer_contract_detailsinstead.@consumer_contract_detailsis never used outside of this class.This PR populates
@consumer_contractinstead of@consumer_contract_details.