changed date published to time ago in words, with full date as mouseover (#145) #164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
One extra requirement - could you put the original date text into a mouseover? Just the generic HTML one will be fine. Oh, ignore this, I just realised you did already. Thanks! |
bethesque
requested changes
Nov 21, 2017
| <span class='name' title='#{published_date}'>Date published:</span> | ||
| <span class='value' title='#{published_date}'> | ||
| #{PactBroker::DateHelper.distance_of_time_in_words(@pact.created_at.to_time, DateTime.now)} ago | ||
| </span> |
There was a problem hiding this comment.
Can you refactor PactBroker::DateHelper.distance_of_time_in_words(@pact.created_at.to_time, DateTime.now) into its own method like the other lines please.
|
Thanks @alexs333! |
YOU54F
pushed a commit
to YOU54F/pact_broker
that referenced
this pull request
Jul 31, 2024
* feat: adding support for share success and failure actions * Merging latest 'main' changes in to Action Object Extensions branch (pact-foundation#170) * chore: suggest multilevel parameters (pact-foundation#155) * chore: suggest multilevel parameters * Update versions/1.0.0.md Co-authored-by: Frank Kilcommins <fkilcommins@gmail.com> * Update examples/1.0.0/ExtendedParametersExample.workflow.yaml Co-authored-by: Frank Kilcommins <fkilcommins@gmail.com> * Update versions/1.0.0.md Co-authored-by: Frank Kilcommins <fkilcommins@gmail.com> --------- Co-authored-by: Frank Kilcommins <fkilcommins@gmail.com> * Remove references to WHATWG to avoid confusion (pact-foundation#145) * Remove references to WHATWG to avoid confusion * Correct relative reference wording * Section 4.2 not 4.1! * Simplify URI wording * Adjust Step Parameters desc to cater for Workflow parameters addition (pact-foundation#169) * feat: add `dependsOn` capability for workflow level (pact-foundation#164) * feat: add `dependsOn` capability for workflow level * chore: typo fix * chore: grammer fix * feat: Add Request Body Object (pact-foundation#162) * feat: Add Request Body Object * chore: fix typos in examples * Clarity on referencing Components Parameters (pact-foundation#149) * Clarity on referencing Components Parameters * Remove Reference Object to avoid clash with JSON Schema keyword. Replace with expression based referencing * chore: keep fixed field link names consistent * chore: Name component parameters as type Reusable Parameter Object * chore: adjust Workflow level parameters to use Reusable Parameter Objects --------- Co-authored-by: Dmytro Anansky <dmytro@redocly.com> Co-authored-by: Nick Denny <nick@apimetrics.com> * Add Reusable Object and referencing ability * chore: fix yaml example indentation * chore: fix JSON examples * chore: fix typo in `workflowStepActions` --------- Co-authored-by: Dmytro Anansky <dmytro@redocly.com> Co-authored-by: Nick Denny <nick@apimetrics.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.