Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Panic when get total account balance #1322

Closed
Ja7ad opened this issue Jun 6, 2024 · 2 comments · Fixed by #1348
Closed

Panic when get total account balance #1322

Ja7ad opened this issue Jun 6, 2024 · 2 comments · Fixed by #1348
Assignees
@ansh-devs
Labels
bug Something isn't working

Comments

@Ja7ad
Copy link
Contributor

Ja7ad commented Jun 6, 2024

Description

When get total balance panic happen on nil conn.

What Happened

image
@Ja7ad Ja7ad added the bug Something isn't working label Jun 6, 2024
@b00f
Copy link
Collaborator

b00f commented Jun 8, 2024

How to Reproduce:

  1. Build the latest code and run the Pactus blockchain locally. Localnet works as well. Read more here.
  2. In a separate terminal, run the following commands: 
    ./build/pactus-shell wallet load-wallet --wallet-name "default_wallet"
./build/pactus-shell wallet get-total-balance --wallet-name "default_wallet"
  3. The Pactus node crashes.

How to Fix

  1. First, ensure the node does not crash on gRPC API failure. Try to catch the panic and log it.
  2. Secondly, fix the above crash.

@b00f b00f mentioned this issue Jun 9, 2024
Merged
@b00f
Copy link
Collaborator

b00f commented Jun 13, 2024

@akbariandev any progress on this issue?

@b00f b00f assigned ansh-devs and unassigned akbariandev Jun 13, 2024
@b00f b00f mentioned this issue Jun 18, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ansh-devs ansh-devs

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor(wallet): set server address on loading wallet b00f/pactus
4 participants
@b00f @Ja7ad @ansh-devs @akbariandev