Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(grpc): improve grpc server and client #1330

Merged
merged 2 commits into from
Jun 10, 2024
Merged

fix(grpc): improve grpc server and client #1330

merged 2 commits into from
Jun 10, 2024

Conversation

Ja7ad
Copy link
Contributor

@Ja7ad Ja7ad commented Jun 9, 2024

Description

  • add GRPC recovery middleware to prevent crash server on grpc
  • add GRPC retry middleware to reconnection client

@Ja7ad Ja7ad requested a review from b00f June 9, 2024 16:11
@b00f
Copy link
Collaborator

b00f commented Jun 9, 2024 •
edited
Loading

@Ja7ad Do you think this fix panic issue in #1322? (Once we have a panic, the node won't terminate.)

@Ja7ad
Copy link
Contributor Author

Ja7ad commented Jun 9, 2024 •
edited
Loading

@Ja7ad Do you think this fix panic issue in #1322? (Once we have a panic, the node won't terminate.)

This middleware prevent crash node panic on all grpc methods, for issue #1322 we need to fix nil client.

@b00f b00f merged commit bdc9dee into pactus-project:main Jun 10, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@b00f b00f b00f approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Ja7ad @b00f