Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(version): add alias to node version #1281

Merged
merged 1 commit into from
May 27, 2024

Conversation

ambersun1234
Copy link
Contributor

Description

This PR add alias to version information

Related issue(s)

#1266

@ambersun1234 ambersun1234 changed the title feature(version): add alias to node version feat(version): add alias to node version May 19, 2024
@Ja7ad Ja7ad requested a review from b00f May 20, 2024 12:56
@b00f
Copy link
Collaborator

b00f commented May 23, 2024

Let's keep ParseVersion for parsing standard version strings (without Alias). Therefore, we don't need to change ParseVersion, and we can keep its logic as it is.

Here, we can add a new function for concatenating Version and alias, called StringWithAlias. This function should be called in the about dialog in the GUI (here) and the version command in the CLI (here).

@b00f b00f merged commit 9c5d7bd into pactus-project:main May 27, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants