Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(jsonrpc): update JSON-RPC Gateway to support headers and improve client registry #1327

Merged
merged 4 commits into from
Jun 9, 2024

Conversation

Ja7ad
Copy link
Contributor

@Ja7ad Ja7ad commented Jun 8, 2024

Description

Update jrpc-gateway to v0.3.1 with new changes:

  • update server and remove http server
  • add graceful shutdown jrpc server
  • remove register services pointer
  • support metadata.MD

@Ja7ad Ja7ad requested a review from b00f June 8, 2024 11:11
Copy link

codecov bot commented Jun 8, 2024

Codecov Report

Attention: Patch coverage is 0% with 8 lines in your changes missing coverage. Please review.

Project coverage is 76.53%. Comparing base (20e991a) to head (658d840).
Report is 17 commits behind head on main.

Current head 658d840 differs from pull request most recent head e2b3373

Please upload reports for the commit e2b3373 to get more accurate results.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1327      +/-   ##
==========================================
+ Coverage   76.05%   76.53%   +0.47%     
==========================================
  Files         206      231      +25     
  Lines       10672    11732    +1060     
==========================================
+ Hits         8117     8979     +862     
- Misses       2169     2336     +167     
- Partials      386      417      +31     

Makefile Outdated Show resolved Hide resolved
@Ja7ad Ja7ad changed the title fix: update jrpc to v1.2.0 with update server fix(grpc): update json rpc gateway to support headers and improve client register Jun 9, 2024
www/jsonrpc/server.go Show resolved Hide resolved
@b00f
Copy link
Collaborator

b00f commented Jun 9, 2024

@Ja7ad make check helps to see the linting issues.

@Ja7ad
Copy link
Contributor Author

Ja7ad commented Jun 9, 2024

@Ja7ad make check helps to see the linting issues.

fixed.

@Ja7ad Ja7ad changed the title fix(grpc): update json rpc gateway to support headers and improve client register fix(grpc): update json rpc gateway to support headers and improve client registery Jun 9, 2024
@Ja7ad Ja7ad changed the title fix(grpc): update json rpc gateway to support headers and improve client registery fix(grpc): update json rpc gateway to support headers and improve client registry Jun 9, 2024
@b00f b00f changed the title fix(grpc): update json rpc gateway to support headers and improve client registry fix(jsonrpc): update json rpc gateway to support headers and improve client registry Jun 9, 2024
@b00f b00f changed the title fix(jsonrpc): update json rpc gateway to support headers and improve client registry fix(jsonrpc): update JSON-RPC Gateway to support headers and improve client registry Jun 9, 2024
@b00f b00f merged commit 19cc2c5 into pactus-project:main Jun 9, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants