Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pactus-shell): pactus shell support basic auth #1384

Merged
merged 4 commits into from
Jul 1, 2024

Conversation

Ja7ad
Copy link
Contributor

@Ja7ad Ja7ad commented Jun 30, 2024

Description

Before pactus shell don't pass authentication basic auth for gRPC, currently supported and pass switchs:

  • --auth-username
  • --auth-password

Related issue(s)

@Ja7ad Ja7ad requested a review from b00f June 30, 2024 10:04
Copy link

codecov bot commented Jun 30, 2024

Codecov Report

Attention: Patch coverage is 0% with 13 lines in your changes missing coverage. Please review.

Project coverage is 76.50%. Comparing base (472c347) to head (b0f3afc).
Report is 16 commits behind head on main.

Current head b0f3afc differs from pull request most recent head 5599bc1

Please upload reports for the commit 5599bc1 to get more accurate results.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1384      +/-   ##
==========================================
- Coverage   77.16%   76.50%   -0.66%     
==========================================
  Files         233      212      -21     
  Lines       11941    10949     -992     
==========================================
- Hits         9214     8377     -837     
+ Misses       2305     2177     -128     
+ Partials      422      395      -27     

@themantre themantre merged commit 22b04e7 into pactus-project:main Jul 1, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Should return error if gRPC has no password, but calls with username and password
3 participants