Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(util): file downloader with verify sha256 hash #1422

Merged
merged 11 commits into from
Jul 17, 2024

Conversation

Ja7ad
Copy link
Contributor

@Ja7ad Ja7ad commented Jul 17, 2024

Description

File downloader with check hash after download

Ja7ad added 4 commits July 9, 2024 12:39
- stop/pause/resume operation in downloading
- realtime stats download
- error signal and known errors
- file details
@Ja7ad Ja7ad added this to the v1.4.0 milestone Jul 17, 2024
@Ja7ad Ja7ad requested review from b00f and kehiy July 17, 2024 07:35
Copy link
Collaborator

@b00f b00f left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything look good. One comment: We can use temp file for tests.

util/downloader/downloader_test.go Outdated Show resolved Hide resolved
Copy link
Contributor

@kehiy kehiy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good to me.

.gitignore Outdated Show resolved Hide resolved
@b00f b00f merged commit 6eec4f4 into pactus-project:main Jul 17, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants