Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cmd): pactus-shell support interactive shell #1460

Merged
merged 5 commits into from
Aug 7, 2024

Conversation

Ja7ad
Copy link
Contributor

@Ja7ad Ja7ad commented Aug 6, 2024

Description

This feature make interactive shell Pactus-shell

asciicast

@Ja7ad Ja7ad added this to the v1.4.1 milestone Aug 6, 2024
go.mod Show resolved Hide resolved
Copy link
Contributor

@kehiy kehiy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Ja7ad Ja7ad requested a review from b00f August 6, 2024 14:46
@b00f
Copy link
Collaborator

b00f commented Aug 7, 2024

@Ja7ad is it possible we have both interactive and non-interactive?

like: pactus-shell -i starts it in interactive format?

@Ja7ad
Copy link
Contributor Author

Ja7ad commented Aug 7, 2024

@Ja7ad is it possible we have both interactive and non-interactive?

like: pactus-shell -i starts it in interactive format?

Sure but with command shell

@Ja7ad
Copy link
Contributor Author

Ja7ad commented Aug 7, 2024

@b00f Currently support interactive and non-interactive shell.

You run as interactive with pactus-shell shell

pactus-shell is a command line tool for interacting with the Pactus blockchain using gRPC

Usage:
  shell [command]

Available Commands:
  blockchain  Blockchain service client
  clear       clear screen
  completion  Generate the autocompletion script for the specified shell
  help        Help about any command
  network     Network service client
  shell       Start an interactive shell.
  transaction Transaction service client
  wallet      Wallet service client

Flags:
  -h, --help   help for shell

Use "shell [command] --help" for more information about a command.

util/shell/shell.go Show resolved Hide resolved
util/shell/shell.go Show resolved Hide resolved
util/shell/shell.go Show resolved Hide resolved
@b00f b00f merged commit e0fb832 into pactus-project:main Aug 7, 2024
10 checks passed
@Ja7ad Ja7ad modified the milestones: v1.4.1, v.1.5.0 Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants