feat(grpc): add Ed25519 to AddressType proto #1492
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ja7ad
reviewed
Aug 29, 2024
| @@ -55,6 +55,9 @@ enum AddressType { | |||
| ADDRESS_TYPE_VALIDATOR = 1; | |||
| // Account address type with BLS signature scheme. | |||
| ADDRESS_TYPE_BLS_ACCOUNT = 2; | |||
| // Account address type with Ed25519 signature scheme. | |||
| // Note: Generating a new Ed25519 address requires the wallet password. | |||
| ADDRESS_TYPE_ED25519_ACCOUNT = 3; | |||
There was a problem hiding this comment.
@b00f For this type need to get wallet password in the message GetNewAddressRequest?
There was a problem hiding this comment.
Yes, We need the password to derive a new address. The reason is explained here:
pactus/crypto/ed25519/hdkeychain/extendedkey.go
Lines 70 to 73 in 0fd3ac2
There was a problem hiding this comment.
Added the password to the GetNewAddress input. Please review again
maxipaz
force-pushed
the
feature/add-ed25519-address-type
branch
from
3ad2178
to
cb380d3
Compare
Ja7ad
approved these changes
Sep 2, 2024
|
@maxipaz Thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding Ed25519 to
AddressTypeprotoRelated issue(s)