Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: increase failed counter when stream encounters errors #489

Merged
merged 1 commit into from
May 29, 2023

Conversation

b00f
Copy link
Collaborator

@b00f b00f commented May 29, 2023

Description

Sometimes, the relay connection encounters errors and gets closed. In such cases, we have increased the 'Send Filed' counter to track the connectivity.

@b00f b00f changed the title fix: increase failed counter when stream got error fix: increase failed counter when stream encounters errors May 29, 2023
@codecov
Copy link

codecov bot commented May 29, 2023

Codecov Report

Merging #489 (bdd908e) into main (b087fe1) will decrease coverage by 0.02%.
The diff coverage is 50.00%.

@@            Coverage Diff             @@
##             main     #489      +/-   ##
==========================================
- Coverage   82.71%   82.70%   -0.02%     
==========================================
  Files         154      154              
  Lines        7255     7256       +1     
==========================================
  Hits         6001     6001              
- Misses        968      969       +1     
  Partials      286      286              

@themantre themantre merged commit 570c7b5 into pactus-project:main May 29, 2023
@b00f b00f deleted the stream-error-send-counter branch May 29, 2023 06:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants