fix(sync): removing state from cache #506
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #506 +/- ##
==========================================
- Coverage 82.83% 82.82% -0.01%
==========================================
Files 154 154
Lines 7289 7285 -4
==========================================
- Hits 6038 6034 -4
Misses 965 965
Partials 286 286 |
b00f
approved these changes
Jun 13, 2023
b00f
reviewed
Jun 13, 2023
b00f
approved these changes
Jun 13, 2023
b00f
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR removes the
stateinstance from thecachein thesyncpackage.Additionally, the block data is now directly passed to the
block_responsemessage without parsing the block, which is expected to improve the performance of the node when processing theblock_requestmessages.