Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove GetValidators rpc method #573

Merged
merged 3 commits into from
Jul 5, 2023

Conversation

ambersun1234
Copy link
Contributor

Description

  • Remove GetValidators RPC method
  • Remove tests that have GetValidators method

Related issue(s)

#515

@b00f
Copy link
Collaborator

b00f commented Jul 5, 2023

@Ja7ad please review and merge

@Ja7ad Ja7ad self-requested a review July 5, 2023 09:07
@codecov
Copy link

codecov bot commented Jul 5, 2023

Codecov Report

Merging #573 (ba1ae03) into main (2167ca9) will decrease coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #573      +/-   ##
==========================================
- Coverage   83.51%   83.50%   -0.02%     
==========================================
  Files         154      154              
  Lines        7255     7250       -5     
==========================================
- Hits         6059     6054       -5     
  Misses        916      916              
  Partials      280      280              

Copy link
Contributor

@Ja7ad Ja7ad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ambersun1234 thank you

@Ja7ad Ja7ad merged commit a967da4 into pactus-project:main Jul 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants