feat: adding Sent and Received bytes per message metrics for peers #618
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 4714af2.
Co-authored-by: b00f <mostafa.sedaghat@gmail.com>
|
I made a mistake while managing my local git branches, and this resulted in 31 commits. 🥲 |
Codecov Report
@@ Coverage Diff @@
## main #618 +/- ##
==========================================
- Coverage 83.56% 83.55% -0.01%
==========================================
Files 154 154
Lines 7264 7274 +10
==========================================
+ Hits 6070 6078 +8
- Misses 912 914 +2
Partials 282 282 |
b00f
requested changes
Aug 1, 2023
|
Hi @b00f Could you kindly review it? |
b00f
approved these changes
Aug 1, 2023
b00f
changed the title
b00f
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Regarding issue #605, I have made some updates. I have added "SentBytes" and "ReceivedBytes" to "peer" and made changes to the "IncreaseReceivedBytesCounter" and "IncreaseSentBytesCounter" functions. Additionally, I have modified the "sendTo" and "broadcast" functions and updated the Protos.
Related issue(s)