Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fixing some minor issues on pre-testnet #719

Merged
merged 3 commits into from
Sep 30, 2023
Merged

Conversation

themantre
Copy link
Contributor

Description

This PR includes some enhancements and fixes for minor issues in the pre-testnet network, including:

  • Checking that the number of rewards addresses is the same as the number of validator addresses.
  • Verifying that the rewards addresses are account addresses and not validator addresses.
  • Improving some log messages.
  • Enhancing the HTTP results.

@codecov
Copy link

codecov bot commented Sep 30, 2023

Codecov Report

Merging #719 (b2be3db) into main (858f6a5) will increase coverage by 0.01%.
The diff coverage is 74.54%.

@@            Coverage Diff             @@
##             main     #719      +/-   ##
==========================================
+ Coverage   83.01%   83.03%   +0.01%     
==========================================
  Files         171      171              
  Lines        7926     7951      +25     
==========================================
+ Hits         6580     6602      +22     
- Misses       1030     1032       +2     
- Partials      316      317       +1     

@amirvalhalla amirvalhalla merged commit 712cc26 into main Sep 30, 2023
12 checks passed
@b00f b00f deleted the pre-testnet-fixes branch October 1, 2023 03:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants