Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(GUI): removing unnecessary tags in transaction confirm dialog #893

Merged
merged 8 commits into from
Jan 2, 2024

Conversation

kehiy
Copy link
Contributor

@kehiy kehiy commented Jan 1, 2024

Description

These HTML tags don't work and just make the dialog annoying.

Example:
Screenshot from 2024-01-01 19-33-09

@kehiy kehiy added enhancement New feature or request Pactus-GUI labels Jan 1, 2024
@kehiy kehiy requested a review from b00f January 1, 2024 19:27
@kehiy kehiy self-assigned this Jan 1, 2024
Copy link

codecov bot commented Jan 1, 2024

Codecov Report

Merging #893 (3fbf875) into main (515cc26) will decrease coverage by 0.10%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #893      +/-   ##
==========================================
- Coverage   83.58%   83.49%   -0.10%     
==========================================
  Files         172      172              
  Lines        8716     8716              
==========================================
- Hits         7285     7277       -8     
- Misses       1087     1092       +5     
- Partials      344      347       +3     

@kehiy kehiy changed the title fix(gui): removing not working tags in transaction confirm dialog fix(GUI): removing unnecessary tags in transaction confirm dialog Jan 1, 2024
@themantre themantre merged commit 4407619 into pactus-project:main Jan 2, 2024
12 checks passed
@kehiy kehiy deleted the hotfix/gui branch January 4, 2024 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Pactus-GUI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants