Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sync): remove ReachabilityStatus from agent info #956

Merged
merged 3 commits into from
Jan 24, 2024

Conversation

vlasfama
Copy link
Contributor

Description

removed ReachabilityStatus.

Related issue(s)

If this Pull Request is related to an issue, mention it here.

  • removed ReachabilityStatus from sync, network and test cases.

Copy link

codecov bot commented Jan 24, 2024

Codecov Report

Merging #956 (63217d3) into main (5309800) will decrease coverage by 0.03%.
The diff coverage is 100.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #956      +/-   ##
==========================================
- Coverage   81.46%   81.44%   -0.03%     
==========================================
  Files         173      173              
  Lines        9185     9184       -1     
==========================================
- Hits         7483     7480       -3     
- Misses       1345     1346       +1     
- Partials      357      358       +1     

@b00f
Copy link
Collaborator

b00f commented Jan 24, 2024

@nagarajmanjunath please fix the linting issues. Read here: https://github.com/pactus-project/pactus/blob/main/CONTRIBUTING.md

@vlasfama vlasfama changed the title Removed ReachabilityStatus from sync, network and fixed test cases. Fix:Removed ReachabilityStatus from sync, network and fixed test cases. Jan 24, 2024
@vlasfama vlasfama changed the title Fix:Removed ReachabilityStatus from sync, network and fixed test cases. fix:Removed ReachabilityStatus from sync, network and fixed test cases. Jan 24, 2024
@vlasfama vlasfama changed the title fix:Removed ReachabilityStatus from sync, network and fixed test cases. fix(sync): Removed ReachabilityStatus from sync, network and fixed test cases. Jan 24, 2024
@vlasfama vlasfama changed the title fix(sync): Removed ReachabilityStatus from sync, network and fixed test cases. fix(sync): Removed ReachabilityStatus Jan 24, 2024
@b00f b00f changed the title fix(sync): Removed ReachabilityStatus fix(sync): remove ReachabilityStatus from sync, network Jan 24, 2024
@b00f b00f changed the title fix(sync): remove ReachabilityStatus from sync, network fix(sync): remove ReachabilityStatus from agent info Jan 24, 2024
@vlasfama vlasfama requested a review from b00f January 24, 2024 16:01
@b00f b00f merged commit 7109186 into pactus-project:main Jan 24, 2024
15 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants